Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle block offset exceeding chunk length in memchunk.go #13661

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

cyriltovena
Copy link
Contributor

The code change in memchunk.go fixes a bug where the block offset plus the length exceeds the chunk length. This bug is addressed by adding a check to ensure that the offset plus length does not exceed the chunk length before accessing the byte slice.

This seems to happen only when a chunk is corrupted and the cause is still unknown.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

The code change in memchunk.go fixes a bug where the block offset plus the length exceeds the chunk length. This bug is addressed by adding a check to ensure that the offset plus length does not exceed the chunk length before accessing the byte slice.

This seems to happen only when a chunk is corrupted and the cause is still unknown.
@cyriltovena cyriltovena requested a review from a team as a code owner July 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants