Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix retry code to handle grpc status codes. updated newer stats retries to be wrapped with spans #13592

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Jul 20, 2024

What this PR does / why we need it:

In our retry middleware we were checking for HTTP status codes to determine if an error should be retried internally, however there are cases where we respond with GRPC status codes that we were not properly handling leading to some transient errors being propagated back to the user which can be caught with simple retries.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…es to be wrapped with spans

Signed-off-by: Edward Welch <[email protected]>
@slim-bean slim-bean requested a review from a team as a code owner July 20, 2024 12:23
@slim-bean slim-bean merged commit d3e1edb into main Jul 20, 2024
62 checks passed
@slim-bean slim-bean deleted the fix-retries branch July 20, 2024 18:35
grafanabot pushed a commit that referenced this pull request Jul 20, 2024
…retries to be wrapped with spans (#13592)

Signed-off-by: Edward Welch <[email protected]>
(cherry picked from commit d3e1edb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants