-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ruler sidecar in singleBinary mode #13572
feat: support ruler sidecar in singleBinary mode #13572
Conversation
I would also need & love this feature! |
Hi @okozachenko1203, |
would be great to have this resolved :) |
any chance to get this merged? |
Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Trevor Whitney <[email protected]>
Thanks for merging this! Just a notice, please update the Chart.yaml in the next time. With this MR semantic versioning has been eliminated. |
Co-authored-by: Trevor Whitney <[email protected]>
Co-authored-by: Trevor Whitney <[email protected]>
What this PR does / why we need it:
support ruler sidecar in singleBinary mode
Which issue(s) this PR fixes:
Fixes #10967
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR