Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added video #13032

Merged
merged 5 commits into from
May 28, 2024
Merged

feat: Added video #13032

merged 5 commits into from
May 28, 2024

Conversation

Jayclifford345
Copy link
Contributor

Added Ingesting basics for Loki video to _index.md of the Send Data directory. Also Updated Grafana Agent to Grafana Alloy.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 added size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories backport release-3.0.x labels May 24, 2024
@Jayclifford345 Jayclifford345 requested a review from a team as a code owner May 24, 2024 14:51
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@JStickler
Copy link
Contributor

@Jayclifford345 could you edit this PR so that it is just adding the video? I've already got a WIP PR for the Alloy changes (and we do not want to delete the Agent references, as the Agent is still supported).

@Jayclifford345
Copy link
Contributor Author

Hey @JStickler! Absolutely, sorry I had put in the request before our conversation on Slack. I reverted my change and just added the video. Let me know if this has changed correctly.

@Jayclifford345
Copy link
Contributor Author

I also got a weird test fail I haven't seem before: check / check / testPackages (pkg/ruler) (pull_request)

 ✖  pkg/ruler/base (15.635s) (coverage: 32.0% of statements)

=== Failed
=== FAIL: pkg/ruler/base TestRuler_PrometheusAlerts (0.00s)
level=info msg="ruler up and running"
    testing.go:1[23](https://github.com/grafana/loki/actions/runs/9265942171/job/25489088416?pr=13032#step:5:24)1: TempDir RemoveAll cleanup: unlinkat /tmp/TestRuler_PrometheusAlerts314236595/001: directory not empty

DONE 283 tests, 1 failure in 94.108s
Error: Process completed with exit code 1.

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit 1432a3e into main May 28, 2024
60 checks passed
@JStickler JStickler deleted the docs-send-data-update branch May 28, 2024 15:44
grafanabot pushed a commit that referenced this pull request May 28, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 1432a3e)
@JStickler JStickler changed the title feat: Added video and updated Grafana Agent -> Alloy feat: Added video Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants