-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix incorrect sorting of chunks in bloom-filtered response since ChunkRef.Cmp
method is used in reverse
#12999
Conversation
…Ref.Cmp` method is used in reverse
ChunkRef.Cmp
method is used in reverseChunkRef.Cmp
method is used in reverse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Instead of inverting the sort here, I think we should invert the Cmp
method to naturally sort in ascending rather than desc order.
Fortunately it's not used anywhere. Modified! |
The
v1.ChunkRef.Cmp()
method is used in reverse, and this can lead to chunks in bloom filtered result be sorted in descending but not ascendingWhat this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR