Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated best practises for labels #12749

Merged
merged 8 commits into from
Apr 24, 2024
Merged

feat: Updated best practises for labels #12749

merged 8 commits into from
Apr 24, 2024

Conversation

Jayclifford345
Copy link
Contributor

  • Added Developer top tips taken from Ed's blog.
  • Added reference to bloom filters
  • Added reference to Alloy

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345
feat: Updated best practises for labels
ea4e852 
* Added Developer top tips taken from Ed's blog.
* Added reference to bloom filters
* Added reference to Alloy
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 23, 2024
@Jayclifford345 Jayclifford345 marked this pull request as ready for review April 23, 2024 10:49
@Jayclifford345 Jayclifford345 requested a review from a team as a code owner April 23, 2024 10:49
JStickler
JStickler reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Couple of suggestions for revisions.

docs/sources/get-started/labels/bp-labels.md Outdated Show resolved Hide resolved
docs/sources/get-started/labels/bp-labels.md Outdated Show resolved Hide resolved
docs/sources/get-started/labels/bp-labels.md Outdated Show resolved Hide resolved
docs/sources/get-started/labels/bp-labels.md Outdated Show resolved Hide resolved
docs/sources/get-started/labels/bp-labels.md Outdated Show resolved Hide resolved
JStickler
JStickler approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM
(Jay and I had discussed removing the Blooms section on Slack)

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 6ebfbe6 into main Apr 24, 2024
59 checks passed
@JStickler JStickler deleted the Jayclifford345-patch-2 branch April 24, 2024 20:46
grafanabot pushed a commit that referenced this pull request Apr 24, 2024
@Jayclifford345 @grafana-delivery-bot
feat: Updated best practises for labels (#12749)
25a943a 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 6ebfbe6)
@grafanabot grafanabot mentioned this pull request Apr 24, 2024
Merged
7 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.0.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jayclifford345 @grafanabot @JStickler