fix: Updated Loki Otlp Ingest Configuration #12648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added some minor updates to the documentation based on my initial walkthrough. * Provided users with the unstructured metadata flag * Updated Loki Address (included port) * Added nesting for otlp_config
|
|
github-actions
bot
added
the
type/docs
Jayclifford345
changed the title
|
Hey @JStickler, I had a stab at updating the doc we discussed yesterday. I am unsure what to do about this doc-validator test. Do I also need to update the template in someway? |
JStickler
reviewed
Apr 17, 2024
There was a problem hiding this comment.
I am unsure what to do about this doc-validator test.
Oh, I have a fix for that, but haven't had a chance to get it implemented yet. Let me get it into a PR and get that merged. Then you can just rebase to pull in the fix and then this should pass doc-validator.
grafanabot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit ff88f3c)
7 tasks
|
Woohoo! Thanks @JStickler |
This was referenced Apr 22, 2024
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some minor updates to the documentation based on my initial walkthrough.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes NA
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR