Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close res body #12444

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: close res body #12444

merged 2 commits into from
Apr 9, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 3, 2024

What this PR does / why we need it:
close res body
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@testwill
fix: close res body
810ece3 
Signed-off-by: guoguangwu <[email protected]>
@testwill testwill requested a review from a team as a code owner April 3, 2024 11:29
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MichelHollands MichelHollands merged commit 616977a into grafana:main Apr 9, 2024
10 checks passed
@testwill testwill deleted the close_res_body branch April 9, 2024 08:50
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@testwill @MichelHollands @rhnasc
fix: close res body (grafana#12444)
c39ed7d 
Signed-off-by: guoguangwu <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
This was referenced Apr 17, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testwill @CLAassistant @MichelHollands