Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruler): enables ruler store that uses clients from thanos-io/objstore pkg #11713

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Jan 19, 2024

What this PR does / why we need it:

Rulers already have the necessary code to use the objstore clients created from thanos-io/objstore pkg.

This pr exposes the ruler_storage block which enables users to configure these clients. This is similar to how mimir ruler storage is configured and helps keep the configuration more consistent across the projects.

  • adds s3 SSE overrides to configure server-side encryption for specific tenant
  • configdb related code is removed since loki never supported it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • docs for ruler_storage are marked hidden. It will be enabled along with other thanos object store blocks before the next minor release along with addition of deprecation notes for existing clients
  • bucket_client_test.go already tests the modules wrapping both objectClient and bucket interfaces

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 19, 2024
@ashwanthgoli ashwanthgoli force-pushed the ashwanth/ruler-thanos-storage branch from fd9a102 to 0a383b8 Compare January 19, 2024 09:42
@ashwanthgoli ashwanthgoli changed the title feat(ruler): add support for using thanos objstore feat(ruler): adds a new ruler store that uses clients from thanos-io/objstore pkg Jan 19, 2024
@ashwanthgoli ashwanthgoli changed the title feat(ruler): adds a new ruler store that uses clients from thanos-io/objstore pkg feat(ruler): enables ruler store that uses clients from thanos-io/objstore pkg Jan 19, 2024
@ashwanthgoli ashwanthgoli force-pushed the ashwanth/ruler-thanos-storage branch from ea3a5d6 to b4350ea Compare October 29, 2024 07:38
@ashwanthgoli ashwanthgoli marked this pull request as ready for review October 29, 2024 07:44
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner October 29, 2024 07:44
@ashwanthgoli ashwanthgoli merged commit 8bca2e7 into main Oct 29, 2024
60 checks passed
@ashwanthgoli ashwanthgoli deleted the ashwanth/ruler-thanos-storage branch October 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants