Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker Hub tags for Loki #1087

Closed
aku opened this issue Sep 30, 2019 · 6 comments · Fixed by #1213
Closed

Fix Docker Hub tags for Loki #1087

aku opened this issue Sep 30, 2019 · 6 comments · Fixed by #1213
Assignees
@sh0rez
Labels
component/packaging keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@aku
Copy link

aku commented Sep 30, 2019

Describe the bug
docker pull grafana/loki:latest command pulls Loki with old API (/api/prom/push instead of /loki/api/v1/pull)

Currently, I have to build from source or provide some label from grafanabot
e.g. grafana/loki:master-42040f2

Expected behavior
Please provide correct labels/tags for Loki images
@aku aku changed the title Fix docker tags for Loki Fix Docker Hub tags for Loki Sep 30, 2019
@cyriltovena cyriltovena added component/packaging keepalive An issue or PR that will be kept alive and never marked as stale. good first issue These are great first issues. If you are looking for a place to start, start here! hacktoberfest labels Sep 30, 2019
@cyriltovena
Copy link
Contributor

cyriltovena commented Sep 30, 2019 •
edited
Loading

The CI needs to be updated to include a push to latest.

@cyriltovena cyriltovena removed good first issue These are great first issues. If you are looking for a place to start, start here! hacktoberfest labels Sep 30, 2019
@slim-bean
Copy link
Collaborator

It looks like when moving to Drone.io for building images we no longer tag master or latest

@sh0rez it doesn't look like drone config calls the make targets for building images, could we updated it to do this so we can get the master and latest tags?

@sh0rez
Copy link
Member

sh0rez commented Sep 30, 2019

I‘ll look into it!

@sh0rez sh0rez self-assigned this Sep 30, 2019
@sandeepsukhani sandeepsukhani mentioned this issue Oct 18, 2019
Closed
@edasque
Copy link

edasque commented Oct 22, 2019

AFAIK, this is still the case. latest is over a month old. Would be nice to version tag too so we can start using SEMVER on something like 0.3

@sh0rez
Copy link
Member

sh0rez commented Oct 22, 2019

Been quite busy for the last weeks, will look into this after I am back from vacation

@slim-bean
Copy link
Collaborator

Version tags exist already v0.3.0 is the most recent, v0.4.0 will be out soon

I will hopefully also get a chance to look at the latest/master tags this week

@slim-bean slim-bean mentioned this issue Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh0rez sh0rez

Labels
component/packaging keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docker latest and master tags grafana/loki
5 participants
@edasque @aku @cyriltovena @slim-bean @sh0rez