-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(promtail): Fix UDP receiver on syslog transport #10708
Conversation
789f260
to
025d2c3
Compare
|
@joshuapare looks like there's some test failures + a merge conflict with the changelog. Assigning myself as reviewer. |
@joshuapare we can move forward here, no issues with the promtail maintenance mode bit. Is there any easy openings for tests here? I'm not very familiar with syslog so I don't know why the reading from the wire needs to be read in this manner to handle UDP. |
@cstyan Unfortunately not - in the other repo, it was deemed simple enough to merge in, so I assume it would follow the same pattern here: grafana/agent#5297 (review) |
fair enough, the agent/alloy team would have worked with this part of the code more recently anyways 👍 lets see if CI is still green, then we can merge |
@joshuapare thanks for your patience 👍 |
@cstyan Same to you! I should have checked back far sooner 😅 thanks for getting this in |
Co-authored-by: Callum Styan <[email protected]>
Simple fix to convert the incoming datagram into a bytes reader that the ParseStream can handle. currently it freezes up because the datagrams are sent as is without separation so the reader routine blocks until an interrupt.
Issue first resolved in grafana/agent, mirror PR to that: grafana/agent#5297
Fixes #6772
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updated