Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review labels consistency in lambda-promtail #10544

Closed
thepalbi opened this issue Sep 11, 2023 · 2 comments · Fixed by #13098
Closed

Review labels consistency in lambda-promtail #10544

thepalbi opened this issue Sep 11, 2023 · 2 comments · Fixed by #13098
Assignees

Comments

@thepalbi
Copy link
Contributor

Lambda promtail adds the __aws_log_type label to entries, to tell apart which was the logging source of that entry. This label is added for s3-based logs, but not for cloudwatch logs for example.

We should review the supported sources, and make these labels consistent.

@thepalbi thepalbi self-assigned this Sep 11, 2023
@spedersen-emailage
Copy link

Looks like kinesis and s3 are the only two that add these labels.

https://github.com/search?q=repo%3Agrafana%2Floki%20__aws_log_type&type=code

@cstyan
Copy link
Contributor

cstyan commented Nov 16, 2023

a test that enforces that this label is always set seems valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants