Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel #3503

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Update otel #3503

merged 2 commits into from
Dec 18, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 14, 2023

What?

Update otel dependencies

Why?

Keeping them up to date.

They are also separate as they:

  1. depend on a lot of other ones
  2. the only use currently is the WIP that @grafana/k6-browser does.

As such I would like at least one member from the browser team to try this changes and tell us if they are getting in the way of their plans.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 14, 2023
@mstoykov mstoykov requested a review from ka3de December 14, 2023 11:23
@mstoykov
Copy link
Contributor Author

I've assigned @ka3de as well as the last person touching those and also as k6 browser team member to check if this makes things harder for them.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fe0563) 73.19% compared to head (47a22f9) 73.19%.
Report is 9 commits behind head on updateGRPC.

❗ Current head 47a22f9 differs from pull request most recent head d4d9cc8. Consider uploading reports for the commit d4d9cc8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           updateGRPC    #3503   +/-   ##
===========================================
  Coverage       73.19%   73.19%           
===========================================
  Files             267      267           
  Lines           20076    20076           
===========================================
  Hits            14694    14694           
  Misses           4468     4468           
  Partials          914      914           
Flag Coverage Δ
ubuntu 73.14% <100.00%> (+<0.01%) ⬆️
windows 73.03% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joanlopez
joanlopez previously approved these changes Dec 14, 2023
ka3de
ka3de previously approved these changes Dec 14, 2023
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that this works with our current main (0fb9eae), which already includes the traces generation implemented in grafana/xk6-browser#1100, just a small fix was required for a test.
So LGTM.

@mstoykov mstoykov added the dependencies Pull requests that update a dependency file label Dec 15, 2023
Base automatically changed from updateGRPC to master December 15, 2023 13:47
@mstoykov mstoykov dismissed stale reviews from ka3de and joanlopez December 15, 2023 13:47

The base branch was changed.

Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mstoykov mstoykov merged commit 973e442 into master Dec 18, 2023
21 checks passed
@mstoykov mstoykov deleted the updateOtel branch December 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants