-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update otel #3503
Update otel #3503
Conversation
I've assigned @ka3de as well as the last person touching those and also as k6 browser team member to check if this makes things harder for them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## updateGRPC #3503 +/- ##
===========================================
Coverage 73.19% 73.19%
===========================================
Files 267 267
Lines 20076 20076
===========================================
Hits 14694 14694
Misses 4468 4468
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that this works with our current main (0fb9eae)
, which already includes the traces generation implemented in grafana/xk6-browser#1100, just a small fix was required for a test.
So LGTM.
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What?
Update otel dependencies
Why?
Keeping them up to date.
They are also separate as they:
As such I would like at least one member from the browser team to try this changes and tell us if they are getting in the way of their plans.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)