-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPU and Network throttling to release notes #3453
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-notes-v0.48.0 #3453 +/- ##
========================================================
Coverage ? 73.36%
========================================================
Files ? 266
Lines ? 19965
Branches ? 0
========================================================
Hits ? 14647
Misses ? 4408
Partials ? 910
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6ed98b6
to
aa093f0
Compare
8842042
to
95224a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it LGTM. I think the examples are good as they are.
As usual I'm doubtful if we should link to some sort of documentation or not, because for example for CPU and network throttling we are mentioning the CPU and network profiles, but it's not clear what fields are available for this.
Thanks for the review! Yep, I wasn't sure either and hoping for some advice on this in the PR. I'll explore adding a bit more detail in here and see if that works. I think linking to docs is also a good approach although I don't feel the docs are stable enough to warrant that yet. Happy to add links though if others have a strong opinion on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
9d9df6d
to
6a450f9
Compare
6a450f9
to
3f309ef
Compare
What?
Adds the
page.throttleCPU
andpage.throttleNetwork
changes to the release notes which were implemented in the browser module.Why?
To notify users of the latest new feature.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Updates: grafana/xk6-browser#887