Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set K6_CLOUD_TRACES_ENABLED to true by default #3398

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Oct 16, 2023

What?

This commit updates the default value of the tracesEnabled option, enabling it by default.

Why?

We hope this change can help drive ease of use of the Distributed Tracing in Grafana Cloud k6 feature.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Enables request metadata output (#3201, #3202) by default.

This commit updates the default value of the `tracesEnabled` option, enabling it by default. We hope this change can help drive ease of use of the Distributed Tracing in Grafana Cloud k6 feature.
@Blinkuu Blinkuu added the cloud label Oct 16, 2023
@Blinkuu Blinkuu requested a review from mstoykov October 16, 2023 13:30
@Blinkuu Blinkuu self-assigned this Oct 16, 2023
@mstoykov mstoykov requested review from a team, olegbespalov and mstoykov and removed request for mstoykov and a team October 16, 2023 13:41
@olegbespalov olegbespalov added this to the v0.48.0 milestone Oct 16, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (43f10a0) 73.12% compared to head (fdd55e4) 73.13%.

❗ Current head fdd55e4 differs from pull request most recent head f22f3e3. Consider uploading reports for the commit f22f3e3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
+ Coverage   73.12%   73.13%   +0.01%     
==========================================
  Files         258      258              
  Lines       19642    19642              
==========================================
+ Hits        14363    14365       +2     
+ Misses       4397     4395       -2     
  Partials      882      882              
Flag Coverage Δ
ubuntu 73.06% <100.00%> (ø)
windows 72.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cloudapi/config.go 90.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov merged commit 9d394ca into master Oct 16, 2023
21 checks passed
@olegbespalov olegbespalov deleted the set-k6-cloud-traces-enabled-to-true branch October 16, 2023 13:53
@Blinkuu Blinkuu mentioned this pull request Jan 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants