Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC reflection v1 #3338

Merged
merged 2 commits into from
Sep 19, 2023
Merged

gRPC reflection v1 #3338

merged 2 commits into from
Sep 19, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Sep 19, 2023

What?

This is a back-port of the grafana/xk6-grpc#48

It brings support of reflection v1 to the k6/net/grpc.

Why?

Reflection v1alpha is deprecated

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Resolve #3222

Changelog

ux: Adds support of the v1 of the gRPC reflection protocol.

Adds support of the v1 of the gRPC reflection protocol.

@olegbespalov olegbespalov self-assigned this Sep 19, 2023
@olegbespalov olegbespalov added this to the v0.47.0 milestone Sep 19, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.66% and no project coverage change.

Comparison is base (2640a6b) 73.17% compared to head (9103545) 73.18%.

❗ Current head 9103545 differs from pull request most recent head 5940a9b. Consider uploading reports for the commit 5940a9b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3338   +/-   ##
=======================================
  Coverage   73.17%   73.18%           
=======================================
  Files         258      258           
  Lines       19912    19887   -25     
=======================================
- Hits        14571    14554   -17     
+ Misses       4416     4413    -3     
+ Partials      925      920    -5     
Flag Coverage Δ
ubuntu 73.11% <91.66%> (-0.01%) ⬇️
windows 73.02% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/netext/grpcext/reflect.go 80.00% <91.66%> (+6.66%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien merged commit 81005d8 into master Sep 19, 2023
22 checks passed
@codebien codebien deleted the feat/reflection-v1 branch September 19, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC reflection will crash when there is no package specifier defined
4 participants