cmd/version: Commit hash #3327
Merged
cmd/version: Commit hash #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
- Coverage 73.20% 73.01% -0.19%
==========================================
Files 258 256 -2
Lines 19895 19910 +15
==========================================
- Hits 14564 14538 -26
- Misses 4406 4439 +33
- Partials 925 933 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
codebien
force-pushed
the
go-readbuildinfo
branch
from
19a769c to
d6a8a1e
Compare
codebien
force-pushed
the
go-readbuildinfo
branch
2 times, most recently
from
29f7aeb to
87e8a3a
Compare
codebien
force-pushed
the
go-readbuildinfo
branch
from
87e8a3a to
d63fb1e
Compare
codebien
requested review from
a team,
oleiade,
olegbespalov and
mstoykov
and removed request for
a team and
olegbespalov
codebien
force-pushed
the
go-readbuildinfo
branch
from
b3a0ba6 to
454aa3d
Compare
mstoykov
reviewed
Sep 8, 2023
| ) | ||
| for _, s := range buildInfo.Settings { | ||
| switch s.Key { | ||
| case "vcs.revision": |
There was a problem hiding this comment.
We even have vcs.time so ... I guess we can even add that if somebody wants 🤷
mstoykov
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Before we were injecting the version details via ldflags. go1.18 introduced the ability to detect the commit directly from the code.
An example of the new format:
Why?
We benefit from it for simplifying our build process and making it more reproducible. It now prints the commit hash instead of the timestamp, in this way should be easier to use in case of troubleshooting and reports.
Related PR(s)/Issue(s)
The original discussion where it started #3322 (comment)