Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/cloudv2: Fix insights client initialization #3184

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Jul 11, 2023

Fixes a bug where K6_CLOUD_TRACES_HOST didn't work with default values.

@Blinkuu Blinkuu self-assigned this Jul 11, 2023
@github-actions github-actions bot requested review from codebien and imiric July 11, 2023 08:01
output/cloud/expv2/output.go Show resolved Hide resolved
@mstoykov mstoykov removed the request for review from imiric July 11, 2023 08:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #3184 (28a9ee9) into master (c66c1be) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 28a9ee9 differs from pull request most recent head e137df8. Consider uploading reports for the commit e137df8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
+ Coverage   72.80%   72.81%   +0.01%     
==========================================
  Files         256      256              
  Lines       19697    19697              
==========================================
+ Hits        14340    14342       +2     
+ Misses       4462     4460       -2     
  Partials      895      895              
Flag Coverage Δ
ubuntu 72.75% <0.00%> (+0.02%) ⬆️
windows 72.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/output.go 64.77% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants