Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document gRPC stram message's metadata #1735

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Sep 23, 2024

What?

This PR does two things:

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/k6#3801

@olegbespalov olegbespalov added the Area: OSS Content Improvements or additions to community/oss documentation label Sep 23, 2024
@olegbespalov olegbespalov self-assigned this Sep 23, 2024
@olegbespalov olegbespalov changed the title Feat/document grpc stream metadata Document gRPC stram message's metadata Sep 23, 2024
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olegbespalov thanks for opening the PR! I made some suggestions to make this more readable, let me know if it makes sense. 🙇

@olegbespalov olegbespalov force-pushed the feat/document-grpc-stream-metadata branch from ed97368 to 74c2244 Compare September 24, 2024 06:35
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, but we likely should rewrit it with the handler having it's own page

@olegbespalov olegbespalov force-pushed the feat/document-grpc-stream-metadata branch from 74c2244 to 3345039 Compare September 24, 2024 08:46
@olegbespalov olegbespalov force-pushed the feat/document-grpc-stream-metadata branch from 3345039 to e751e1c Compare September 24, 2024 08:48
@olegbespalov olegbespalov merged commit 23ec317 into main Sep 25, 2024
5 checks passed
@olegbespalov olegbespalov deleted the feat/document-grpc-stream-metadata branch September 25, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants