-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bar Gauge: Add field name placement option #75932
Conversation
… gauge is in horizontal orientation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! Added a question about the naming.
docs/sources/panels-visualizations/visualizations/bar-gauge/index.md
Outdated
Show resolved
Hide resolved
@nmarrs should not be named "name placement" option? it does not look like it's changing the value placement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! Made some suggestions.
docs/sources/panels-visualizations/visualizations/bar-gauge/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/bar-gauge/index.md
Outdated
Show resolved
Hide resolved
Tested locally and works well! I noticed 2 things - the option is not shown for hidden Screen.Recording.2023-10-04.at.10.30.12.PM.mov |
😅 not sure what I was thinking - updated the naming to be |
… orientation is set
"Field label" might be confusin also, since fields actually have labels, and this is not that 😅 . @torkelo suggested "Name placement", which is probably better? what do we do in other panels? in bar chart we call it both X-axis labels and X-axis tick labels (probably should remove "tick"). it's tricky there because BarChart can show timestamps on X, so calling it Names felt weird. In StateTimeline we don't call them anything because we dont have any options for them yet, but Name/Names is probably what we'll go with when we add options for truncation and alignment control. We already use "Axis label" in other panels, which is something different. Naming is hard :( |
yes - naming is hard 🙃 I think I would be fine with any of the following: |
done - thanks for catching this / the suggestion @adela-almasan :) |
- **Text color -** Value color is default text color. | ||
- **Hidden -** Values are hidden. | ||
|
||
### Field label placement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think name is better term than field label. In the sister panel Stat we refer to it as Name , and in settings we refer to it as "Display name" , never label.
So think "Name placement" as the option name is best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Updated behavior (with
namePlacement
)up.to.date.v2.mov
Auto (before)
auto.original.behavior.mov
Auto / Top / Left
all.of.the.options.mov
Fixes #75928