CloudWatch: Fix broken queries for users migrating from 8.2.4/8.2.5 to 8.3.0 #42611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
type/bug
datasource/CloudWatch
backport v8.3.x
sunker
requested review from
joshhunt and
kaydelaney
and removed request for
a team
torkelo
approved these changes
Dec 1, 2021
sunker
changed the title
sunker
added a commit
that referenced
this pull request
Dec 2, 2021
…o 8.3.0 (#42611) (#42616) * move migration logic to a higher version number * bump version in test (cherry picked from commit ee9ca20) Co-authored-by: Erik Sundell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In 8.2.4, a bug that caused nested panels not to be migrated, was fixed in this PR. While doing so, the migration code was refactored so that the panelUpgrades array was used, locking the migration to a schema version lower than 32 instead of running the migration every time the dashboard migrator is executed. At the same time, we've been working on adding support for CloudWatch Metrics Insights in a private repo. In this private repo, we've added yet more migrations, however these were based on the initial version of the dashboard migrator that was not depending on a certain schema version. Consequently, the migration necessary for Metrics Insights are not being executed, causing all CloudWatch queries to break. Note that this is only a problem for users upgrading from 8.2.4 or 8.2.5 to 8.3.0, since that's the only way to get schema version 32.
This PR simply moves these migrations from schema version 32 to schema version 34.
Which issue(s) this PR fixes:
Fixes #42598
Special notes for your reviewer:
Tested this by exporting a pre-configured cloudwatch dashboards from 8.0.0 and 8.2.4 and importing them in main, and I can confirm it's working fine.