Alerting: Clear alerting rule evaluation errors after intermittent failures #42386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures When an alert transitioned in a way that `alerting -> error -> (alerting|nodata)`, the error provided by the `error` state would never be cleared thus the API and UI would show the health as an error.
gotjosh
requested review from
JohnnyQQQQ,
davidmparrott and
santihernandezc
and removed request for
a team
gotjosh
added
add to changelog
backport v8.3.x
gotjosh
commented
Nov 26, 2021
| @@ -118,6 +121,8 @@ func (a *State) resultError(alertRule *ngModels.AlertRule, result eval.Result) { | |||
| } | |||
|
|
|||
| func (a *State) resultNoData(alertRule *ngModels.AlertRule, result eval.Result) { | |||
| a.Error = result.Error | |||
There was a problem hiding this comment.
The issue was originally reported and found in the Alerting state but I realised that this would also happen when the data is noData.
grafanabot
pushed a commit
that referenced
this pull request
Nov 26, 2021
…ilures (#42386) * Alerting: Clear alerting rule evaluation errors after intermittent failures When an alert transitioned in a way that `alerting -> error -> (alerting|nodata)`, the error provided by the `error` state would never be cleared thus the API and UI would show the health as an error. (cherry picked from commit dd5a2e5)
gotjosh
added a commit
that referenced
this pull request
Nov 26, 2021
…ilures (#42386) (#42391) * Alerting: Clear alerting rule evaluation errors after intermittent failures When an alert transitioned in a way that `alerting -> error -> (alerting|nodata)`, the error provided by the `error` state would never be cleared thus the API and UI would show the health as an error. (cherry picked from commit dd5a2e5) Co-authored-by: gotjosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an alert transitioned in a way that
alerting -> error -> (alerting|nodata), the error provided by theerrorstate would never be cleared thus the API and UI would show the health as an error.