Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Prevent folders from being deleted when they contain alerts #42307

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

peterholmberg
Copy link
Contributor

What this PR does / why we need it:
Changing behavior from automatically deleting alerts to prevent folders from being deleted if they contain alerts.

Which issue(s) this PR fixes:

Fixes #39175

Special notes for your reviewer:

@peterholmberg peterholmberg added this to the 8.3.0 milestone Nov 25, 2021
@peterholmberg peterholmberg self-assigned this Nov 25, 2021
@peterholmberg peterholmberg requested a review from a team as a code owner November 25, 2021 14:55
@peterholmberg peterholmberg requested review from joshhunt, kaydelaney, gillesdemey, papagian and pkolyvas and removed request for a team November 25, 2021 14:55
Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterholmberg peterholmberg merged commit 8692f57 into main Nov 29, 2021
@peterholmberg peterholmberg deleted the alerting-do-not-force-delete-rules branch November 29, 2021 13:25
grafanabot pushed a commit that referenced this pull request Nov 29, 2021
armandgrillet pushed a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend backport v8.3.x Mark PR for automatic backport to v8.3.x
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ngAlert: When I delete a folder, my alerts are deleted without warning
2 participants