Plugins Catalog: Enable install controls based on the pluginAdminEnabled flag #41686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
requested review from
axelavargas and
thisisobate
and removed request for
a team
leventebalogh
requested review from
a team and
ashharrison90
and removed request for
a team,
axelavargas,
thisisobate and
ashharrison90
leventebalogh
force-pushed
the
leventebalogh/remove-deprecated-plugin-components
branch
from
b8635d0 to
c00bb60
Compare
5 tasks
jackw
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Great stuff @leventebalogh 👏
Took it for a spin and works as expected.
I'm guessing we need to change the feature flag behaviour before we can merge any of these "remove deprecated code" PRs otherwise we'll break main for anyone which has the feature flag set false?
Yes, that's right, thanks for pointing it out mate. Will merge the other 2 outstanding PRs into this one before merging the whole if it is fine with you? |
leventebalogh
force-pushed
the
leventebalogh/remove-deprecated-plugin-components
branch
from
767b16f to
95fb70d
Compare
leventebalogh
force-pushed
the
leventebalogh/remove-deprecated-plugin-components
branch
from
95fb70d to
3c9b035
Compare
* refactor(plugins): use the plugins/admin reducer only
* refactor(plugins): remove tests for the deprecated plugins reducer
* refactor(plugins): remove tests for the deprecated plugins selectors
* refactor(plugins/state): add a short comment note to selectors
* feat(plugins/state): add a selector for selecting errors
* feat(plugins/state): add a hook for getting plugin errors
* refactor(plugins): udpate the PluginsErrorsInfo component to use the new state selectors
* refactor(plugins/state): remove the old (deprecated) selectors
* refactor(plugins/state): use the new actions under /admin
* refactor(plugins/state): remove old (deprecated) reducers and actions
* refactor(plugins): update component definition
* fix(plugins): remove unnecessary {children} prop for PluginsErrorsInfo
…d` flag (#41749) * docs(plugins): update documentation for the `plugin_admin_enabled` flag * refactor(InstallControls): move the main component to a named module * feat(plugins): use the `pluginAdminEnable` flag to hide / show install controls in the UI * test(plugins): add tests for enabling/disabling install controls
leventebalogh
requested review from
achatterjee-grafana and
osg-grafana
and removed request for
a team
…nents * main: (22 commits) Refactor drone yaml (#41937) Update latest.json (#41873) Fix loop when cannot fetch roles (#41901) AzureMonitor: Fix metric namespace clear (#41878) Access Control: use role groups in role picker (#41912) AccessControl: RolePicker fetch roles in org (#41927) add unsupported renderer message to catalog (#41898) Install netcat to build-container and update the version (#41825) Transformers: extract fields from JSON and text (alpha) (#41791) Candlestick: fix volume histogram height by using mapped field name (#41931) Geomap: Improve geojson style editor (#41926) Docs: Add configuration option for the image renderer (#41798) Chore: Move babel config to a root babel.config.json (#41615) Make initialize depend on clone, only on enterprise pipelines (#41909) Run integration tests after initialize (#41906) Datasource: Fix stable sort order of query responses (#41868) Disable lint-drone from release pipelines (#41899) Add basic resource trimming command (#41780) Update grabpl version to 2.6.1 (#41892) Azure Monitor: Clean up fields when editing Metrics (#41762) ...
grafanabot
added
the
type/docs
leventebalogh
deleted the
leventebalogh/remove-deprecated-plugin-components
branch
grafanabot
pushed a commit
that referenced
this pull request
Nov 25, 2021
* refactor(plugins): use routes specific to the new plugins/admin * refactor(plugins): remove unused pages (PluginList, PluginItem) * refactor(plugins): remove PluginPage * refactor(plugins): remove UpdatePluginModal * refactor(plugins): move AppConfigWrapper under plugins/admin * refactor(plugins): move PluginDashboards under plugins/admin * refactor(plugins): rename the "specs" folder to "tests" * refactor(plugins): move test files to /tests folder * refactor(plugins): move AppRootPage into a /components folder * refactor(plugins): move PluginsErrorsInfo into a /plugins folder * refactor(plugins): move PluginSettingsCache into a /components folder * refactor(plugins): move PluginStateInfo into a /plugins folder * refactor(plugins): move AppRootPage.test.tsx next to the tested component * refactor(plugins): remove old snapshot tests * fix(plugins): fix tests * refactor(plugins/admin): move & rename PluginSettingsCache * fix(plugins): fix a few rebase issues * Plugins: remove deprecated code (state handling) (#41739) * refactor(plugins): use the plugins/admin reducer only * refactor(plugins): remove tests for the deprecated plugins reducer * refactor(plugins): remove tests for the deprecated plugins selectors * refactor(plugins/state): add a short comment note to selectors * feat(plugins/state): add a selector for selecting errors * feat(plugins/state): add a hook for getting plugin errors * refactor(plugins): udpate the PluginsErrorsInfo component to use the new state selectors * refactor(plugins/state): remove the old (deprecated) selectors * refactor(plugins/state): use the new actions under /admin * refactor(plugins/state): remove old (deprecated) reducers and actions * refactor(plugins): update component definition * fix(plugins): remove unnecessary {children} prop for PluginsErrorsInfo * Plugins: show / hide install controls based on the `pluginAdminEnabled` flag (#41749) * docs(plugins): update documentation for the `plugin_admin_enabled` flag * refactor(InstallControls): move the main component to a named module * feat(plugins): use the `pluginAdminEnable` flag to hide / show install controls in the UI * test(plugins): add tests for enabling/disabling install controls (cherry picked from commit 35c2c95)
leventebalogh
changed the title
jackw
pushed a commit
that referenced
this pull request
Nov 25, 2021
* refactor(plugins): use routes specific to the new plugins/admin * refactor(plugins): remove unused pages (PluginList, PluginItem) * refactor(plugins): remove PluginPage * refactor(plugins): remove UpdatePluginModal * refactor(plugins): move AppConfigWrapper under plugins/admin * refactor(plugins): move PluginDashboards under plugins/admin * refactor(plugins): rename the "specs" folder to "tests" * refactor(plugins): move test files to /tests folder * refactor(plugins): move AppRootPage into a /components folder * refactor(plugins): move PluginsErrorsInfo into a /plugins folder * refactor(plugins): move PluginSettingsCache into a /components folder * refactor(plugins): move PluginStateInfo into a /plugins folder * refactor(plugins): move AppRootPage.test.tsx next to the tested component * refactor(plugins): remove old snapshot tests * fix(plugins): fix tests * refactor(plugins/admin): move & rename PluginSettingsCache * fix(plugins): fix a few rebase issues * Plugins: remove deprecated code (state handling) (#41739) * refactor(plugins): use the plugins/admin reducer only * refactor(plugins): remove tests for the deprecated plugins reducer * refactor(plugins): remove tests for the deprecated plugins selectors * refactor(plugins/state): add a short comment note to selectors * feat(plugins/state): add a selector for selecting errors * feat(plugins/state): add a hook for getting plugin errors * refactor(plugins): udpate the PluginsErrorsInfo component to use the new state selectors * refactor(plugins/state): remove the old (deprecated) selectors * refactor(plugins/state): use the new actions under /admin * refactor(plugins/state): remove old (deprecated) reducers and actions * refactor(plugins): update component definition * fix(plugins): remove unnecessary {children} prop for PluginsErrorsInfo * Plugins: show / hide install controls based on the `pluginAdminEnabled` flag (#41749) * docs(plugins): update documentation for the `plugin_admin_enabled` flag * refactor(InstallControls): move the main component to a named module * feat(plugins): use the `pluginAdminEnable` flag to hide / show install controls in the UI * test(plugins): add tests for enabling/disabling install controls (cherry picked from commit 35c2c95) Co-authored-by: Levente Balogh <[email protected]>
jackw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #40503
What changed
plugins/adminThe clean-up is going to be done in batches (smaller separate PRs). Upcoming ones are cleaning up the plugin state handling and
removing the feature flagchanging how the feature-flag works for the plugins catalog.