Alerting: fix bug where user is able to access rules from namespaces user is not part of #41403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jean-Philippe Quéméner <[email protected]>
gotjosh
requested review from
davidmparrott,
santihernandezc,
grobinson-grafana,
kminehart and
dsotirakis
and removed request for
a team
armandgrillet
added
the
old backport v8.2.x
grobinson-grafana
requested changes
Nov 8, 2021
Co-authored-by: George Robinson <[email protected]>
grobinson-grafana
approved these changes
Nov 8, 2021
Co-authored-by: George Robinson <[email protected]>
Co-authored-by: George Robinson <[email protected]>
|
Looks good to me, just need to rebase and fix the commit message! |
armandgrillet
changed the title
armandgrillet
changed the title
grafanabot
pushed a commit
that referenced
this pull request
Nov 8, 2021
…user is not part of (#41403) * Add fix * Add tests Co-authored-by: Yuriy Tseretyan <[email protected]> Co-authored-by: Armand Grillet <[email protected]> Co-authored-by: Jean-Philippe Quéméner <[email protected]> Co-authored-by: George Robinson <[email protected]> (cherry picked from commit 6220872)
leventebalogh
added a commit
that referenced
this pull request
Nov 8, 2021
* main: (47 commits) Chore: Prevent loading error from showing too early (#41347) Chore: add context to login (#41316) Update dependency memoize-one to v6 (#41349) Docs: Added note that only string type is supported for query variables. (#41359) Alerting: fix bug where user is able to access rules from namespaces user is not part of (#41403) prometheus: enable new monaco-based query field (#41357) Chore: Go mod tidy (#41374) PanelEdit: Show when field options have override rules or data config that overrides the default (#40250) NodeGraph: Fix subTitle and secondaryStat being truncated in some cases (#40244) MarketTrend: add devenv dashboard (#41334) MarketTrend: add new alpha panel (#40909) StateTimeline: Share cursor with rest of the panels (#41038) Chore: cleanup ES query_builder test (#41360) Prometheus: Fix showing of errors (#41356) Update dependency lru-cache to v6 (#41327) api/ds/query: simplify data sources lookup for queries and expressions (#41172) A11y/UserAdminPage: Improves tab navigation and focus management (#41321) influxdb: improved explanation texts (#41351) prometheus: monaco: fix a corner-case with quotes (#41345) process app plugins first (#41346) ...
armandgrillet
pushed a commit
that referenced
this pull request
Nov 8, 2021
…user is not part of (#41403) * Add fix * Add tests Co-authored-by: Yuriy Tseretyan <[email protected]> Co-authored-by: Armand Grillet <[email protected]> Co-authored-by: Jean-Philippe Quéméner <[email protected]> Co-authored-by: George Robinson <[email protected]> (cherry picked from commit 6220872)
armandgrillet
added a commit
that referenced
this pull request
Nov 8, 2021
…user is not part of (#41403) (#41406) * Add fix * Add tests (cherry picked from commit 6220872) Co-authored-by: Yuriy Tseretyan <[email protected]> Co-authored-by: Armand Grillet <[email protected]> Co-authored-by: Jean-Philippe Quéméner <[email protected]> Co-authored-by: George Robinson <[email protected]> Co-authored-by: gotjosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug where a user is able to access rules from namespaces that the user is not part of.