Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Ensure consistent plugin settings list response #41346

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Nov 5, 2021

Which issue(s) this PR fixes:

Fixes #41314

Special notes for your reviewer:
This could be done in one loop instead of two, but I thought that this was a bit clearer to follow. Feedback on this welcome

@wbrowne wbrowne added type/bug add to changelog old backport v8.2.x Mark PR for automatic backport to v8.2.x labels Nov 5, 2021
@wbrowne wbrowne added this to the 8.2.4 milestone Nov 5, 2021
@wbrowne wbrowne self-assigned this Nov 5, 2021
@wbrowne wbrowne requested a review from a team as a code owner November 5, 2021 10:58
@wbrowne wbrowne requested review from marefr and kminehart and removed request for a team November 5, 2021 10:58
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great stuff

@wbrowne wbrowne merged commit 8a42fca into main Nov 5, 2021
@wbrowne wbrowne deleted the fix-41314 branch November 5, 2021 14:07
@grafanabot

This comment has been minimized.

@wbrowne wbrowne removed the old backport v8.2.x Mark PR for automatic backport to v8.2.x label Nov 5, 2021
@wbrowne
Copy link
Member Author

wbrowne commented Nov 5, 2021

Was manually backported to 8.2.x here #41365

leventebalogh added a commit that referenced this pull request Nov 8, 2021
* main: (47 commits)
  Chore: Prevent loading error from showing too early (#41347)
  Chore: add context to login (#41316)
  Update dependency memoize-one to v6 (#41349)
  Docs: Added note that only string type is supported for query variables. (#41359)
  Alerting: fix bug where user is able to access rules from namespaces user is not part of (#41403)
  prometheus: enable new monaco-based query field (#41357)
  Chore: Go mod tidy (#41374)
  PanelEdit: Show when field options have override rules or data config that overrides the default  (#40250)
  NodeGraph: Fix subTitle and secondaryStat being truncated in some cases (#40244)
  MarketTrend: add devenv dashboard (#41334)
  MarketTrend: add new alpha panel (#40909)
  StateTimeline: Share cursor with rest of the panels (#41038)
  Chore: cleanup ES query_builder test (#41360)
  Prometheus: Fix showing of errors (#41356)
  Update dependency lru-cache to v6 (#41327)
  api/ds/query: simplify data sources lookup for queries and expressions (#41172)
  A11y/UserAdminPage: Improves tab navigation and focus management (#41321)
  influxdb: improved explanation texts (#41351)
  prometheus: monaco: fix a corner-case with quotes (#41345)
  process app plugins first (#41346)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins: An app plugin's child plugins are sometimes not enabled even when AutoEnabled: true
3 participants