Explore: Prevent empty Elasticsearch logs query responses from hiding the logs panel #40217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elfo404
force-pushed
the
gio/fix/empty-log-response
branch
from
e072dad to
8c2cf45
Compare
Elfo404
requested review from
a team,
davkal,
gabor and
ivanahuckova
and removed request for
a team
Elfo404
force-pushed
the
gio/fix/empty-log-response
branch
from
8c2cf45 to
f8cdb22
Compare
Elfo404
changed the title
Elfo404
changed the title
Elfo404
added a commit
that referenced
this pull request
Oct 12, 2021
… the logs panel (#40217) (#40329) * remove return value from addPreferredVisualisationType * Elasticsearch: send empty series instead when no data is received for a query (cherry picked from commit b0391d4) Co-authored-by: Giordano Ricci <[email protected]>
chri2547
changed the title
osg-grafana
changed the title
|
Reverted change to PR title to conform to style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When issuing logs queries, it may happen that for a given time range there are no entries. Instead of returning nothing, we should return an empty series to prevent the logs panel from disappearing in explore, especially when using logs pagination since it would force users to manually change the time range from the topo-level time picker.
Which issue(s) this PR fixes:
Fixes #38679
Special notes for your reviewer: