Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add short url validation #38436

Merged
merged 2 commits into from
Aug 26, 2021
Merged

API: Add short url validation #38436

merged 2 commits into from
Aug 26, 2021

Conversation

idafurjes
Copy link
Contributor

@idafurjes idafurjes commented Aug 23, 2021

Add some additional validation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@marefr marefr self-requested a review August 23, 2021 10:46
@marefr marefr modified the milestones: 8.0.7, 8.1.3 Aug 23, 2021
@idafurjes idafurjes added the old backport v8.1.x Mark PR for automatic backport to v8.1.x label Aug 23, 2021
@idafurjes idafurjes changed the title Add short url validation API: Add short url validation Aug 23, 2021
@idafurjes idafurjes marked this pull request as ready for review August 23, 2021 12:53
@idafurjes idafurjes requested a review from a team as a code owner August 23, 2021 12:53
@idafurjes idafurjes requested review from kminehart and removed request for a team August 23, 2021 12:53
idafurjes and others added 2 commits August 24, 2021 09:37
Path should not contain string ../
Co-authored-by: Marcus Efraimsson <[email protected]>
@idafurjes idafurjes force-pushed the short_url_validation branch from 166fdb9 to 7a4043a Compare August 24, 2021 07:38
@idafurjes idafurjes requested a review from marefr August 25, 2021 12:43
@idafurjes idafurjes merged commit 7faea40 into main Aug 26, 2021
@idafurjes idafurjes deleted the short_url_validation branch August 26, 2021 07:07
grafanabot pushed a commit that referenced this pull request Aug 26, 2021
* Add short url validation
Path should not contain string ../

* Update pkg/api/short_url.go

Co-authored-by: Marcus Efraimsson <[email protected]>

Co-authored-by: Marcus Efraimsson <[email protected]>
(cherry picked from commit 7faea40)
idafurjes added a commit that referenced this pull request Aug 26, 2021
* Add short url validation
Path should not contain string ../

* Update pkg/api/short_url.go

Co-authored-by: Marcus Efraimsson <[email protected]>

Co-authored-by: Marcus Efraimsson <[email protected]>
(cherry picked from commit 7faea40)

Co-authored-by: idafurjes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend old backport v8.1.x Mark PR for automatic backport to v8.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants