-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres/MySQL/MSSQL: Change time field to "Time" for time series queries #36720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime series queries
idafurjes
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ryantxu
reviewed
Jul 13, 2021
marefr
commented
Jul 13, 2021
marefr
commented
Jul 13, 2021
Co-authored-by: Ryan McKinley <[email protected]>
torkelo
approved these changes
Jul 14, 2021
grafanabot
pushed a commit
that referenced
this pull request
Jul 14, 2021
… time series queries (#36720) Name of time field changed in v8 for time series queries from Time to the name of the selected time column, i.e. time or time_sec. These changes should make sure that the name of time field is always returned as Time for time series queries. Fixes #36059 Co-authored-by: Ryan McKinley <[email protected]> (cherry picked from commit 10c892f)
kaydelaney
pushed a commit
that referenced
this pull request
Jul 14, 2021
… time series queries (#36720) (#36746) Name of time field changed in v8 for time series queries from Time to the name of the selected time column, i.e. time or time_sec. These changes should make sure that the name of time field is always returned as Time for time series queries. Fixes #36059 Co-authored-by: Ryan McKinley <[email protected]> (cherry picked from commit 10c892f) Co-authored-by: Marcus Efraimsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
datasource/MSSQL
Microsoft SQL Server Data Source
datasource/MySQL
datasource/Postgres
old backport v8.0.x
Mark PR for automatic backport to v8.0.x
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Name of time field changed in v8 for time series queries from
Time
to the name of the selected time column, i.e.time
ortime_sec
. These changes should make sure that the name of time field is always returned asTime
for time series queries.Which issue(s) this PR fixes:
Fixes #36059
Special notes for your reviewer: