Library Panels: Add name endpoint & unique name validation to AddLibraryPanelModal #33987
Conversation
…dLibraryPanelModal
kaydelaney
requested review from
aknuds1 and
dsotirakis
and removed request for
a team
No, it's global. Should it be per folder? |
|
|
||
| // getLibraryElementByName gets a Library Element by name. | ||
| func (l *LibraryElementService) getLibraryElementByName(c *models.ReqContext) (LibraryElementDTO, error) { | ||
| return l.getLibraryElement(c, map[string]interface{}{"name": c.Params(":name")}) |
There was a problem hiding this comment.
The name should be unique within an Org so I think you need org_id as a param here too?
There was a problem hiding this comment.
Ah, you're right, will change
There was a problem hiding this comment.
Also, I think we need kind, and folder_id here too
I agree with Torkel, within the same folder, kind and org the name should be unique or should be exactly the same as the UniqueKey defined here: |
|
Hmm, if we just want the name to be unique per folder (per kind, per org), should the name endpoint be able to return multiple library panels if several exist with the same name in different folders? |
I think returning an array with elements should do it! |
| }, [debouncedPanelTitle]); | ||
|
|
||
| const invalidInput = | ||
| !isValidTitle?.value && isValidTitle.value !== undefined && panelTitle === debouncedPanelTitle && !waiting; |
There was a problem hiding this comment.
Settled on the use of waiting here to avoid a small bit of jank that I couldn't find a way to work around otherwise.
Initially I had wanted to use !isValidTitle.loading as one of the conditions here, but this resulted in a flash between valid/invalid styles when editing an invalid title to a valid one.
The reason this happens is that, when the user starts typing panelTitle no longer equals debouncedPanelTitle, so invalidInput becomes false, and the valid styling is used.
When the user stops typing, after 350ms debouncedPanelTitle equals panelTitle. I had hoped then, that the useAsync callback would execute and set isValidTitle.loading to true, thus keeping invalidInput false, but I suspect because of some event loop weirdness this doesn't happen for a frame or two, and so we get a flash of invalid styling before isValidTitle.loading settles on being true.
Anyway, if anyone knows a nicer way to do this, let me know.
kaydelaney
changed the title
byName endpoint & unique name validation to AddLibraryPanelModalname endpoint & unique name validation to AddLibraryPanelModal
public/app/features/library-panels/components/AddLibraryPanelModal/AddLibraryPanelModal.tsx
Outdated
Show resolved
Hide resolved
hugohaggmark
added
the
old backport v8.0.x
public/app/features/library-panels/components/AddLibraryPanelModal/AddLibraryPanelModal.tsx
Outdated
Show resolved
Hide resolved
kaydelaney
changed the title
name endpoint & unique name validation to AddLibraryPanelModalname endpoint & unique name validation to AddLibraryPanelModal
…braryPanelModal (#33987) (#34285) (cherry picked from commit c778d6a) Co-authored-by: kay delaney <[email protected]>
jackw
changed the title
name endpoint & unique name validation to AddLibraryPanelModal
What this PR does / why we need it:
Adds a
byNameendpoint to the library elements api in service of unique name validation forAddLibraryPanelModal.