Graphite: Expand metric names for variables #33694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifrost
requested review from
a team,
oddlittlebird,
achatterjee-grafana,
osg-grafana and
gabor
and removed request for
a team
grafanabot
added
datasource/Graphite
type/docs
Co-authored-by: achatterjee-grafana <[email protected]>
Co-authored-by: achatterjee-grafana <[email protected]>
Yes! Sorry, forgot about the milestone. Updated and adding "add to changelog" label. |
achatterjee-grafana
suggested changes
May 4, 2021
Co-authored-by: achatterjee-grafana <[email protected]>
Co-authored-by: achatterjee-grafana <[email protected]>
Co-authored-by: achatterjee-grafana <[email protected]>
Co-authored-by: achatterjee-grafana <[email protected]>
Co-authored-by: achatterjee-grafana <[email protected]>
achatterjee-grafana
approved these changes
May 5, 2021
ryantxu
pushed a commit
that referenced
this pull request
May 13, 2021
* Allow expanding metrics names in variable queries * Simplify docs * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Clean up docs Co-authored-by: achatterjee-grafana <[email protected]>
mortenaa
pushed a commit
to mortenaa/grafana
that referenced
this pull request
May 25, 2021
* Allow expanding metrics names in variable queries * Simplify docs * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Update docs/sources/datasources/graphite.md Co-authored-by: achatterjee-grafana <[email protected]> * Clean up docs Co-authored-by: achatterjee-grafana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Variable query for Graphite allows to search for metrics, however it's quite limited because results contain possible values but occurring only at the last level of the query (please check the example below). This PR introduces "expand" function allowing to use expand API to get the full name of matching metrics. In combination with regex it will allow to extract any part of the metric name.
Example:
Metrics:
prod.servers.server001.cpuprod.servers.server002.cputest.servers.server001.cpuSearch results: (normal query is already available, expanded query support is added in this PR)
*expand(*)*.serversexpand(*.servers)test.serversexpand(test.servers)*.servers.*expand(*.servers.*)test.servers.*expand(test.servers.*)*.servers.*.cpuexpand(*.servers.*.cpu)Why is it important?
The available implementation allows to handle only simpler (though most common) cases where only the last part of the metric should become a variable value. However, it's not possible extract other parts of metric names.
Imagine you needed a dropdown to select the environment (
prodortestin the example above). Normal search could capture the top level name but only of all metrics you have. Let's say besidesprod.*andtest.*metrics you hadstatsd.*. With normal query "statsd" would also be captured. With "expand" it's possible to write do this:Query:
expand(*.servers)Regex:
/^(\w+).*/Expand will first find only metrics that have
serversin the second level and then regex will capture only environment names.How to test it?
Run:
make devenv sources=graphiteSend some sample data: https://gist.github.com/ifrost/ada07138775d5295fba169d27abddf8d
Create a dashboard with following query:
$env.servers.$server.cpuCreate variables:
env:and
server:Which issue(s) this PR fixes:
Fixes #2343
Special notes for your reviewer: Same example is included in updated docs.