Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: Allow setting a custom limit for log queries #32422

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

Elfo404
Copy link
Contributor

@Elfo404 Elfo404 commented Mar 29, 2021

Related to #24236.

As pointed out in #24236 (comment) it's not a definitive solution to the issue, but it may mitigate the pain a bit.

also, it fixes the behavior of the query editor as In the previous version bucket aggregations and other metrics were ignored, so they are now removed from the editor as well.
Screenshot 2021-03-29 at 12 59 34

/cc @simianhacker do you think this could be a viable short term solution?

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot! 👍Maybe it is not a final solution, but adding an option to set the number of logs user would like to receive is great feature.

@Elfo404 Elfo404 added this to the 8.0.0 milestone Apr 1, 2021
@Elfo404 Elfo404 force-pushed the gio/feat/configurable-logs-limit branch from 6137fb0 to 608baa0 Compare April 13, 2021 09:52
@Elfo404 Elfo404 marked this pull request as ready for review April 13, 2021 09:53
@Elfo404 Elfo404 requested a review from a team April 13, 2021 09:53
@Elfo404 Elfo404 force-pushed the gio/feat/configurable-logs-limit branch from 608baa0 to b33f82b Compare April 13, 2021 16:15
@Elfo404 Elfo404 merged commit 1597890 into master Apr 13, 2021
@Elfo404 Elfo404 deleted the gio/feat/configurable-logs-limit branch April 13, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants