-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Never disable add new data source for core plugins #81774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that isFullyInstalled
is used in another place (usePluginConfig
). Wouldn't it be more correct to say that core plugins are fully installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, LGTM!
What is this feature?
Never disable "Add new data source" for core plugin in cloud
Why do we need this feature?
This feature is needed to fix the issue where the button "Add new data source" is disabled for cloud plugins
Who is this feature for?
Plugins users
Which issue(s) does this PR fix?:
Fixes #81766
Special notes for your reviewer:
Please check that: