-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix firing alerts title when showing active in Insights panel #80414
Merged
soniaAguilarPeiron
merged 3 commits into
main
from
alerting/fix-alerts-firing-count-in-insights
Jan 12, 2024
Merged
Alerting: Fix firing alerts title when showing active in Insights panel #80414
soniaAguilarPeiron
merged 3 commits into
main
from
alerting/fix-alerts-firing-count-in-insights
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
type/bug
area/alerting
Grafana Alerting
area/frontend
add to changelog
no-backport
Skip backport of PR
labels
Jan 12, 2024
soniaAguilarPeiron
requested review from
gillesdemey and
konrad147
and removed request for
a team
January 12, 2024 08:51
gillesdemey
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
soniaAguilarPeiron
force-pushed
the
alerting/fix-alerts-firing-count-in-insights
branch
from
January 12, 2024 10:57
bcea985
to
2d2cd98
Compare
soniaAguilarPeiron
changed the title
Alerting: Fix firing alerts in Insights panel
Alerting: Fix firing alerts title when showing active in Insights panel
Jan 12, 2024
…iring-count-in-insights
/deploy-to-hg |
|
|
gillesdemey
approved these changes
Jan 12, 2024
soniaAguilarPeiron
deleted the
alerting/fix-alerts-firing-count-in-insights
branch
January 12, 2024 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/alerting
Grafana Alerting
area/frontend
no-backport
Skip backport of PR
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes Insights panel title for showing firing alerts count.
So far, this panel was counting alerts with 'active' state when an active rule is not always firing, so the number is incorrect.
After reviewing the rest of the panels, we realised that actually there is another panel showing the firing count. So, we think that the problem here is not the count but the title, as there is no other panel showing active alerts.
Who is this feature for?
All cloud users.
Which issue(s) does this PR fix?:
Fixes #80348
Please check that: