Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Fix firing alerts title when showing active in Insights panel #80414

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron commented Jan 12, 2024

What is this feature?

This PR fixes Insights panel title for showing firing alerts count.
So far, this panel was counting alerts with 'active' state when an active rule is not always firing, so the number is incorrect.

After reviewing the rest of the panels, we realised that actually there is another panel showing the firing count. So, we think that the problem here is not the count but the title, as there is no other panel showing active alerts.

Who is this feature for?

All cloud users.

Which issue(s) does this PR fix?:

Fixes #80348

Screenshot 2024-01-12 at 13 51 27

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 10.4.x milestone Jan 12, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Jan 12, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner January 12, 2024 08:51
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey and konrad147 and removed request for a team January 12, 2024 08:51
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.4.x, 10.3.x Jan 12, 2024
@grafana grafana deleted a comment from ephemeral-instances-bot bot Jan 12, 2024
@grafana grafana deleted a comment from ephemeral-instances-bot bot Jan 12, 2024
Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting/fix-alerts-firing-count-in-insights branch from bcea985 to 2d2cd98 Compare January 12, 2024 10:57
@soniaAguilarPeiron soniaAguilarPeiron changed the title Alerting: Fix firing alerts in Insights panel Alerting: Fix firing alerts title when showing active in Insights panel Jan 12, 2024
@soniaAguilarPeiron
Copy link
Member Author

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes.
  • Check the GitHub actions tab to follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with alerting/fix-alerts-firing-count-in-insights oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@soniaAguilarPeiron soniaAguilarPeiron merged commit 4ea997b into main Jan 12, 2024
14 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting/fix-alerts-firing-count-in-insights branch January 12, 2024 15:47
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.3.x, 10.4.x Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Alert insights do count active rules instead of firing rules.
3 participants