Flamegraph: Update threshold for collapsing and fix flickering #78206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
added
type/bug
area/frontend
add to changelog
no-backport
aocenas
commented
Nov 15, 2023
| useEffect(() => { | ||
| if (data) { | ||
| setCollapsedMap(data.getCollapsedMap()); | ||
|
|
||
| let levels = data.getLevels(); |
There was a problem hiding this comment.
Instead of useMap for the collapseMap and separate useEffect for the levels computation this is done in single effect which synchronizes those 2 values and prevent flickering on double rerenders.
aocenas
commented
Nov 15, 2023
| @@ -82,22 +77,6 @@ export function nestedSetToLevels( | |||
| level: currentLevel, | |||
| }; | |||
|
|
|||
| if (options?.collapsing) { | |||
There was a problem hiding this comment.
This logic was moved to separate class for easier testing and also the whole logic was moved to after whole tree is computed. Otherwise we could not use any heuristic about how many children a parent can have as we don't have all the children at this point of the code.
aocenas
commented
Nov 15, 2023
| } | ||
| } | ||
|
|
||
| addTree(root: LevelItem) { |
There was a problem hiding this comment.
Because we need to know how many children item has we need to wait for the whole tree to be done and than do another pass over it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Before the collapsing groups in flamegraph were done only in cases parent and child had the same value. This was pretty strict and with lot's of samples even very thin wrapper code could accrue some difference in value so this changes the default threshold to min 0.99 of the parent.
Also this synchronizes the creation of the collapse map and other data so that the flamegraph is rendered with the collapsed groups on first render.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: