Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Move transformation addition to a drawer #74197

Closed
Tracked by #74194
codeincarnate opened this issue Aug 31, 2023 · 5 comments · Fixed by #78299
Closed
Tracked by #74194

Transformations: Move transformation addition to a drawer #74197

codeincarnate opened this issue Aug 31, 2023 · 5 comments · Fixed by #78299
Labels
internal for issues made by grafanistas

Comments

@codeincarnate
Copy link
Contributor

The current tab UI transformations leaves the transformations hanging out in a sea of text.

Screenshot 2023-08-31 at 10 05 35 AM

In this situation for those not familiar with Grafana design language it may be difficult to notice that this is a clickable UI element as it appears to be a text label because of its relative positioning.

We're using this to track some experiments to see if we can make this look a bit more clickable.

@codeincarnate codeincarnate added the internal for issues made by grafanistas label Aug 31, 2023
@codeincarnate
Copy link
Contributor Author

Draft PR with experiments here: #74240

@codeincarnate
Copy link
Contributor Author

Current:

Screen.Recording.2023-08-31.at.4.59.10.PM.mov

@torkelo
Copy link
Member

torkelo commented Sep 1, 2023

@codeincarnate we use the same tab design as GitHub and many websites, so I doubt this is a big issue, but if it improves the design of tabs and works everywhere we show tabs, then maybe. I wish we could have more rounded corners, Grafana is so angular :(

@codeincarnate
Copy link
Contributor Author

Thanks for the feedback @torkelo 🙏 We're curious to see if this will work so we're planning on testing it to see what kind of results we get in this context. I hadn't thought too much about how this might apply more broadly but I'll give it some thought 😄

@codeincarnate
Copy link
Contributor Author

Currently working on some issues with tab position messing up 😢

Image

@codeincarnate codeincarnate changed the title Transformations: Test More Prominent Tab UI Transformations: Move transformation addition to a drawer Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal for issues made by grafanistas
Projects
None yet
2 participants