Catalog: Display badges for Angular plugins and disable install if Angular is disabled #69084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnyo
added
area/plugins
area/frontend
javascript
xnyo
commented
May 25, 2023
public/app/features/plugins/admin/components/InstallControls/ExternallyManagedButton.tsx
Show resolved
Hide resolved
xnyo
changed the title
3 tasks
xnyo
added
no-backport
xnyo
changed the title
academo
reviewed
Jun 13, 2023
public/app/features/plugins/admin/components/PluginDetailsAngularDeprecation.tsx
Outdated
Show resolved
Hide resolved
academo
reviewed
Jun 13, 2023
public/app/features/plugins/admin/components/PluginDetailsPage.tsx
Outdated
Show resolved
Hide resolved
academo
reviewed
Jun 13, 2023
public/app/features/plugins/admin/components/PluginDetailsAngularDeprecation.tsx
Outdated
Show resolved
Hide resolved
mckn
approved these changes
Jun 26, 2023
public/app/features/plugins/admin/components/Badges/PluginAngularBadge.tsx
Outdated
Show resolved
Hide resolved
public/app/features/plugins/admin/components/PluginDetailsAngularDeprecation.tsx
Outdated
Show resolved
Hide resolved
| target="_blank" | ||
| rel="noreferrer" | ||
| > | ||
| Read more about Angular support deprecation. |
There was a problem hiding this comment.
@shih-chris Could you advise what we would need to add here in order to start tracking whether a user from an organization has clicked this link?
sympatheticmoose
approved these changes
Jun 27, 2023
xnyo
added
add to changelog
and removed
no-changelog
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
…gular is disabled (#69084) * Angular deprecation: Add Angular badge in plugin catalog page * Angular deprecation: Add alert in plugin details page * Angular deprecation: Disable install button if for Angular plugins * removed extra console.log * Add tests for Angular badge * Add tests for PluginDetailsAngularDeprecation * Add tests for InstallControlsButton * Add tests for ExternallyManagedButton * Table tests * Catalog: Update angular deprecation message * PR review feedback * Update tests * Update copy for angular tooltip and alert * Update tests * Fix test warnings * Fix angularDetected not being set for remote catalog plugins * Dynamic alert text based on grafana config * Moved deprecation message to a separate function * Removed unused Props in PluginAngularBadge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When Angular support is disabled in the instance:
It changes some UI elements in the plugins catalog only for Angular plugins:
Plugins catalog page
Plugin details page
Why do we need this feature?
Improves Angular deprecation discoverability for operators when browsing the plugins catalog.
Who is this feature for?
Grafana operators
Which issue(s) does this PR fix?:
Related to #68974
Special notes for your reviewer:
Requires the following PRs to be merged in GCOM, so
isAngularis returned by the API:Please check that: