From a0b153f4289d471ef417be8dc6fd783ec2a95478 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel=20Ortu=C3=B1o?= Date: Thu, 10 Feb 2022 09:13:16 +0100 Subject: [PATCH] bump default gRPC send max size to 100Mb (#123) * bump gRPC send max size to 100Mb * updated CHANGELOG.md * Fixed CHANGELOG Signed-off-by: Marco Pracucci Co-authored-by: Marco Pracucci --- CHANGELOG.md | 1 + crypto/tls/test/tls_integration_test.go | 2 +- grpcclient/grpcclient.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d8bab82e0..de87dfbfb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ * [CHANGE] grpcutil.Resolver.Resolve: Take a service parameter. #102 * [CHANGE] grpcutil.Update: Remove gRPC LB related metadata. #102 * [CHANGE] concurrency.ForEach: deprecated and reimplemented by new `concurrency.ForEachJob`. #113 +* [CHANGE] grpcclient: Bump default `grpc-max-send-msg-size` flag to 100 Mb. #123 * [CHANGE] ring/client: It's now possible to set different value than `consul` as default KV store. #120 * [CHANGE] Lifecycler: Default value of lifecycler's `final-sleep` is now `0s` (i.e. no sleep). #121 * [CHANGE] Lifecycler: It's now possible to change default value of lifecycler's `final-sleep`. #121 diff --git a/crypto/tls/test/tls_integration_test.go b/crypto/tls/test/tls_integration_test.go index 0e9d5f899..720aab47c 100644 --- a/crypto/tls/test/tls_integration_test.go +++ b/crypto/tls/test/tls_integration_test.go @@ -584,7 +584,7 @@ type grpcConfig struct { // RegisterFlags registers flags. func (cfg *grpcConfig) RegisterFlags(f *flag.FlagSet) { f.IntVar(&cfg.MaxRecvMsgSize, ".grpc-max-recv-msg-size", 100<<20, "gRPC client max receive message size (bytes).") - f.IntVar(&cfg.MaxSendMsgSize, ".grpc-max-send-msg-size", 16<<20, "gRPC client max send message size (bytes).") + f.IntVar(&cfg.MaxSendMsgSize, ".grpc-max-send-msg-size", 100<<20, "gRPC client max send message size (bytes).") f.StringVar(&cfg.GRPCCompression, ".grpc-compression", "", "Use compression when sending messages. Supported values are: 'gzip', 'snappy' and '' (disable compression)") f.Float64Var(&cfg.RateLimit, ".grpc-client-rate-limit", 0., "Rate limit for gRPC client; 0 means disabled.") f.IntVar(&cfg.RateLimitBurst, ".grpc-client-rate-limit-burst", 0, "Rate limit burst for gRPC client.") diff --git a/grpcclient/grpcclient.go b/grpcclient/grpcclient.go index e7d93b64e..284b64a31 100644 --- a/grpcclient/grpcclient.go +++ b/grpcclient/grpcclient.go @@ -39,7 +39,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { // RegisterFlagsWithPrefix registers flags with prefix. func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) { f.IntVar(&cfg.MaxRecvMsgSize, prefix+".grpc-max-recv-msg-size", 100<<20, "gRPC client max receive message size (bytes).") - f.IntVar(&cfg.MaxSendMsgSize, prefix+".grpc-max-send-msg-size", 16<<20, "gRPC client max send message size (bytes).") + f.IntVar(&cfg.MaxSendMsgSize, prefix+".grpc-max-send-msg-size", 100<<20, "gRPC client max send message size (bytes).") f.StringVar(&cfg.GRPCCompression, prefix+".grpc-compression", "", "Use compression when sending messages. Supported values are: 'gzip', 'snappy' and '' (disable compression)") f.Float64Var(&cfg.RateLimit, prefix+".grpc-client-rate-limit", 0., "Rate limit for gRPC client; 0 means disabled.") f.IntVar(&cfg.RateLimitBurst, prefix+".grpc-client-rate-limit-burst", 0, "Rate limit burst for gRPC client.")