Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug which prevented the app_agent_receiver integration from processing traces #4655

Merged

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jul 31, 2023

PR Description

This issue was introduced during the latest Otel upgrade (#3858). Unfortunately, it has been preventing the app_agent_receiver integration from processing traces completely.

Which issue(s) this PR fixes

Fixes #4632

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@ptodev ptodev requested review from a team as code owners July 31, 2023 15:04
@ptodev ptodev linked an issue Jul 31, 2023 that may be closed by this pull request
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptodev ptodev force-pushed the 4632-faro-demo-doesnt-start-anymore-with-latest-grafana-agent-035 branch from e2d8bd9 to cb30be5 Compare August 1, 2023 11:10
@ptodev ptodev merged commit 2693b4f into main Aug 1, 2023
@ptodev ptodev deleted the 4632-faro-demo-doesnt-start-anymore-with-latest-grafana-agent-035 branch August 1, 2023 11:43
ptodev added a commit that referenced this pull request Aug 4, 2023
…rocessing traces (#4655)

* Save otel factories in traces instance

* Try an http request periodically
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
…rocessing traces (#4655)

* Save otel factories in traces instance

* Try an http request periodically
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
…rocessing traces (#4655)

* Save otel factories in traces instance

* Try an http request periodically
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faro demo doesn't start anymore with latest grafana agent (0.35)
2 participants