Go mod fixes after the collector upgrade #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
approved these changes
Jun 30, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Go mod fixes after the collector upgrade * Update to version 0.80
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Go mod fixes after the collector upgrade * Update to version 0.80
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes to the go.mod file which I forgot to push to my branch prior to merging #3858, apologies!
In addition, I had to update from version 0.79 to 0.80, because it contains Erik's changes. According to the collector and collector-contrib changelogs there are no breaking changes. I also eyeballed the metrics produced on
localhost:12345/metricsby version 0.34.3 against this version, and they seem ok to me.