Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test on Windows #4313

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix broken test on Windows #4313

merged 1 commit into from
Jun 30, 2023

Conversation

thampiotr
Copy link
Contributor

PR Description

My previous PR #4303 caused one windows test to fail to build, but we don't run windows tests as a merge gate, so I missed this.

This should fix the compilation error.

@thampiotr thampiotr marked this pull request as ready for review June 30, 2023 09:51
@thampiotr thampiotr requested a review from a team as a code owner June 30, 2023 09:51
@ptodev ptodev merged commit 230b3fb into main Jun 30, 2023
@ptodev ptodev deleted the thampiotr/fix-windows-test branch June 30, 2023 09:56
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants