Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalRefMap/LabelStore should check staleness markers and/or other garbage collections #5585

Closed
mattdurham opened this issue Oct 24, 2023 · 1 comment · Fixed by #5970
Closed

GlobalRefMap/LabelStore should check staleness markers and/or other garbage collections #5585

mattdurham opened this issue Oct 24, 2023 · 1 comment · Fixed by #5970
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention.

Comments

@mattdurham
Copy link
Collaborator

Request

GlobalRefMap can leak 16 bytes + label per label. This can cause higher than expected memory usage in high cardinality environments.

Use case

Reduce memory usage of global ref map. Add staleness checks, though this is likely not a full solution since honor timestamps and metrics receiver can prevent this.
@mattdurham mattdurham added the enhancement New feature or request label Oct 24, 2023
@mattdurham mattdurham mentioned this issue Oct 24, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Nov 24, 2023
@mattdurham mattdurham mentioned this issue Dec 13, 2023
Merged
2 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention.
Projects
No open projects
Grafana Agent (Public)
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add code to check for staleness in labelstore grafana/agent
1 participant
@mattdurham