Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata is not persisting in flow mode #3515

Closed
mattdurham opened this issue Apr 11, 2023 · 1 comment
Closed

Metadata is not persisting in flow mode #3515

mattdurham opened this issue Apr 11, 2023 · 1 comment
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@mattdurham
Copy link
Collaborator

Passing a nil at the end of this ensures that metadata doesn't work.

https://github.com/grafana/agent/blob/main/component/prometheus/remotewrite/remote_write.go#L82

On first pass this seems hard to fix due to the fact there is NOT a tight coupling between remote_write and scrape.
@mattdurham mattdurham added type/core flow Related to Grafana Agent Flow labels Apr 11, 2023
@rfratto
Copy link
Member

rfratto commented Apr 11, 2023

Closing as dupe of grafana/alloy#547

@rfratto rfratto closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Grafana Agent (Public) Apr 11, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Grafana Agent (Public)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfratto @mattdurham