Fix invalid class generated when extracting ABI from enum type #31437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
force-pushed
the
lptr/execution/fix-abi-extraction-bug-2
branch
from
8ec2f5e
to
3cf2b85
Compare
lptr
force-pushed
the
lptr/execution/fix-abi-extraction-bug-2
branch
from
3cf2b85
to
41011f2
Compare
lptr
force-pushed
the
lptr/execution/fix-abi-extraction-bug-2
branch
from
41011f2
to
2dd07e1
Compare
lptr
commented
Nov 27, 2024
Comment on lines
+114
to
+117
| if ((classMember.getAccess() & ACC_ENUM) == ACC_ENUM) { | ||
| // Enum constructors have an implicit String and int parameter containing | ||
| // the name and ordinal of the value that is non-annotable. | ||
| return Optional.of(2); |
There was a problem hiding this comment.
💭 This is the main change in the PR: we are now also handling enum constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31436
This fixes the problem with annotated enum constructors where the constructor would end up having one more
RuntimeVisibleAnnotationsentry recorded, causing compilation errors when trying to compile against the extracted class.Reviewing cheatsheet
Before merging the PR, comments starting with