RoomSchema workaround not working as expected

[vikasraimeesho]

I have added the room workaround block in the app module but looks like its not working.

room {
    schemaLocationDir = file("roomSchemas")
}

Here are the details

Task Setup Issues

Task declares the same output directory as task hiltJavaCompileDebug from dagger.hilt.android.plugin: '/Users/vikasrai/AndroidStudioProjects/supply_android/app/build/roomSchemas/compileDebugJavaWithJavac'.

Plugin: com.android.application
Task: compileDebugJavaWithJavac
Task type: org.gradle.api.tasks.compile.JavaCompile
Issues for the same task were detected in 1 module(s), total execution time was 9.5s (2.8%), by module:
  Execution mode: FULL, time: 9.5s (2.8%), determines build duration: true, on critical path: true, issues: Task Setup Issues

====Build information:====
Execution date: 25/11/22, 12:36 AM
Total build duration: 342.9s
Configuration time: 2.7s (0.8%)
Critical path tasks time: 338.7s (98.8%)
Critical path tasks size: 45
AGP versions: 7.2.2, 7.2.0
====Platform information:====
AI-213.7172.25.2113.9123335, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.0, screens 3456.0x2234.0; Retina

AS: Dolphin | 2021.3.1 Patch 1
Kotlin plugin: 213-1.7.20-release-for-android-studio-AS6777.52
Android Gradle Plugin: 7.2.2
Gradle: 7.3.3
Gradle JDK: version 11.0.13
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: (not found)

[runningcode]

Hi @vikasraimeesho , we have tested the RoomSchema workaround with Gradle 7.3.3 and AGP 7.2.2. Can you clarify what you mean by "not working". What was the expected result and what actually happened? Where does this message you are sharing come from?

[vikasraimeesho]

@runningcode
We’re getting this warning in the Android Studio's build analyzer tool. This is warning message

I was under the impression cache fix plugin will fix this issue. Not sure if its really related to cache fix plugin or dagger hilt issue. Looks like hiltJavaCompileDebug and compileDebugJavaWithJavac trying to use the same output directory.
I have checked with the local build cache disabled and removing the cache fix plugin then there was no such warning in the same scenario.

[runningcode]

This is a bug in the Hilt Gradle Plugin. It copies CommandLineArgumentProviders from the main JavaCompile tasks to it's own JavaCompile tasks. If any one of these CommandLineArgumentProviders declares an output, it will be overlapping when the second task also receives the same output directory.

See this bug for more details: google/dagger#3546

Could you try using the task configuration avoidance API in your project to see if the overlapping outputs goes away?

[vikasraimeesho]

Thanks for the clarification. Sure, I'll try this.

[vikasraimeesho]

Do you mean to use task configuration avoidance api for hiltJavaCompileDebug?

https://github.com/google/dagger/blob/master/java/dagger/hilt/android/plugin/main/src/main/kotlin/dagger/hilt/android/plugin/HiltGradlePlugin.kt#L384

But here in the code they're using task configuration avoidance api.

[runningcode]

I mean in your buildscript source code as well as all your third party plugins, make sure that none are using eager task configuration in order to avoid this issue.

[cdsap]

hi, Hilt team merged the fix google/dagger@b7c0d3e creating a new HiltCommandLineArgumentProvider. Will test again when they publish new release

[vikasraimeesho]

@cdsap Thanks for the update

[cdsap]

Hi @vikasraimeesho
We tested the new Hilt release(2.45) and the issue is fixed:
https://ge.solutions-team.gradle.com/s/vtgc2fn6zm2dc/timeline?details=imlwwf4k5v4yg

Before:
https://ge.solutions-team.gradle.com/s/2xm5wwyxydhdw/timeline?details=imlwwf4k5v4yg

Closing the issue