Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow container to take full-width #919

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix: allow container to take full-width #919

merged 5 commits into from
Jun 28, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 27, 2024 •
edited
Loading

In this PR:

  • drop sx prop from FileItem
  • drop showCaption prop from FileItem
  • make audio full-width
  • default sizing to full-width
  • default alignement to center for content that has a known mimetype, other mimetypes that display as button are left-aligned
  • add alignment conversion function from SDK back here
  • export a captionWrapper as a simple component, keep the possibility of usign it as an HOC

@spaenleh spaenleh requested a review from pyphilia June 28, 2024 11:18
@spaenleh spaenleh self-assigned this Jun 28, 2024
@spaenleh spaenleh added feature New feature or request chore Generic task 👀 visual A UI related issue labels Jun 28, 2024
pyphilia
pyphilia approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@spaenleh spaenleh added this pull request to the merge queue Jun 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
@spaenleh
fix: allow container to take full-width (#919)
aa55bc2 
* fix: allow container to take full-width

* fix: update sizing default

* fix: update caption wrapper

* fix: make audio full-width
@spaenleh spaenleh removed this pull request from the merge queue due to a manual request Jun 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh enabled auto-merge June 28, 2024 14:40
@spaenleh spaenleh added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit ca35529 Jun 28, 2024
3 checks passed
@graasper graasper mentioned this pull request Jun 28, 2024
Merged
@spaenleh spaenleh deleted the container-width branch July 1, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
chore Generic task 👀 visual A UI related issue feature New feature or request v4.20.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia