Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playwright install issue #834

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: playwright install issue #834

merged 2 commits into from
Apr 30, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Apr 29, 2024

It looks like when playwright is added from the cache the test complain because there is something missing. So in this PR I install playwright both if the cache is found and if it is missing. Hopefully this fixes the issue.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@spaenleh spaenleh requested review from pyphilia and ReidyT April 29, 2024 07:24
@spaenleh spaenleh self-assigned this Apr 29, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working build 🔨 labels Apr 29, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@spaenleh spaenleh added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 500059c Apr 30, 2024
3 checks passed
@spaenleh spaenleh deleted the fix-playwright-install-issue branch May 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working build 🔨 v4.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants