Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): use item name when alttext is falsy #415

Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 30, 2023

The altText should default to the item name when it is undefined or ''. This is not the best but at least assistive technologies will not skip it.

@spaenleh spaenleh linked an issue Jun 30, 2023 that may be closed by this pull request
@spaenleh spaenleh self-assigned this Jun 30, 2023
@spaenleh spaenleh requested a review from MalinSvenberg June 30, 2023 13:59
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jun 30, 2023
Copy link
Contributor

@MalinSvenberg MalinSvenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spaenleh spaenleh merged commit 32ee9e8 into main Jul 10, 2023
@spaenleh spaenleh deleted the 414-use-item-name-as-a-default-for-empty-string-alttext branch July 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v3.2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use item name as a default for empty string altText
2 participants