Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280 creative commons #281

Merged
merged 19 commits into from
May 8, 2023
Merged

280 creative commons #281

merged 19 commits into from
May 8, 2023

Conversation

clementcharmillot
Copy link
Contributor

@clementcharmillot clementcharmillot commented Mar 11, 2023

Storybook view:

image

Effect on hover:

image

closes #280

@clementcharmillot clementcharmillot self-assigned this Mar 16, 2023
@clementcharmillot clementcharmillot marked this pull request as ready for review March 23, 2023 12:47
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I have a few questions which we can discuss if they should require changes.
I may have resolved the merge conflicts from main wrong. @spaenleh can you let me know (see comment)?

@codeofmochi codeofmochi force-pushed the 280-creative-commons branch from 1936375 to 161d5b5 Compare April 28, 2023 15:56
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments from @dialexo it looks good to me.

Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you all for your work

@spaenleh spaenleh merged commit 0fc9a0f into main May 8, 2023
@codeofmochi codeofmochi deleted the 280-creative-commons branch May 8, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Creative Commons component
3 participants