From 07ff296b100fdb468d33e36631e5b112b933697e Mon Sep 17 00:00:00 2001 From: spaenleh Date: Tue, 6 Jun 2023 11:20:09 +0200 Subject: [PATCH 1/4] fix: add missing keys --- src/constants/library.ts | 2 ++ src/langs/fr/library.json | 1 + 2 files changed, 3 insertions(+) diff --git a/src/constants/library.ts b/src/constants/library.ts index 456be64e..cf80fdea 100644 --- a/src/constants/library.ts +++ b/src/constants/library.ts @@ -1,4 +1,6 @@ export const LIBRARY = { + GRAASP_LIBRARY: 'GRAASP_LIBRARY', + GRAASP_LIBRARY_DESCRIPTION: 'GRAASP_LIBRARY_DESCRIPTION', SHARE_TWITTER_MESSAGE: 'SHARE_TWITTER_MESSAGE', SHARE_FACEBOOK_SUBJECT: 'SHARE_FACEBOOK_SUBJECT', SHARE_FACEBOOK_MESSAGE: 'SHARE_FACEBOOK_MESSAGE', diff --git a/src/langs/fr/library.json b/src/langs/fr/library.json index 7f409281..b001ea15 100644 --- a/src/langs/fr/library.json +++ b/src/langs/fr/library.json @@ -1,6 +1,7 @@ { "COPY_LINK_BUTTON_TOOLTIP": "Copier le lien", "GRAASP_LIBRARY": "Graasp Library", + "GRAASP_LIBRARY_DESCRIPTION": "Graasp Library est une platforme de partage de resources éducatives libres.", "HOME_TITLE": "Découvrez des ressources libres pour l'éducation", "GUEST": "Invité", "SEARCH_RANGES_AUTHOR": "Auteur", From 43dd7cb23f0daf7b0abe91ada2a6cc00ba571d42 Mon Sep 17 00:00:00 2001 From: spaenleh Date: Tue, 6 Jun 2023 12:19:58 +0200 Subject: [PATCH 2/4] feat: add search title for library --- src/constants/library.ts | 1 + src/langs/de/library.json | 1 + src/langs/en/library.json | 1 + src/langs/fr/library.json | 1 + 4 files changed, 4 insertions(+) diff --git a/src/constants/library.ts b/src/constants/library.ts index cf80fdea..74ffa322 100644 --- a/src/constants/library.ts +++ b/src/constants/library.ts @@ -32,6 +32,7 @@ export const LIBRARY = { 'ALL_COLLECTIONS_SELECTION_BY_CATEGORIES_TITLE', HEADER_MY_LISTS: 'HEADER_MY_LISTS', HEADER_ALL_COLLECTIONS: 'HEADER_ALL_COLLECTIONS', + SEARCH_PAGE_TITLE: 'SEARCH_PAGE_TITLE', SEARCH_RANGE_LABEL: 'SEARCH_RANGE_LABEL', SEARCH_RANGES_ALL: 'SEARCH_RANGES_ALL', SEARCH_RANGES_TITLE: 'SEARCH_RANGES_TITLE', diff --git a/src/langs/de/library.json b/src/langs/de/library.json index 3379d6b2..ea1d1c64 100644 --- a/src/langs/de/library.json +++ b/src/langs/de/library.json @@ -29,6 +29,7 @@ "ALL_COLLECTIONS_CLEAR_SELECTION_BUTTON": "Auswahl löschen", "ALL_COLLECTIONS_SELECTION_BY_CATEGORIES_TITLE": "Sammlungen in ausgewählten Kategorien", "HEADER_MY_LISTS": "Meine Listen", + "SEARCH_PAGE_TITLE": "Graasp Suche", "SEARCH_RANGE_LABEL": "Suchbereich", "SEARCH_RANGES_ALL": "Alle", "SEARCH_RANGES_TITLE": "Titel", diff --git a/src/langs/en/library.json b/src/langs/en/library.json index d37b444e..de716c6c 100644 --- a/src/langs/en/library.json +++ b/src/langs/en/library.json @@ -30,6 +30,7 @@ "ALL_COLLECTIONS_CLEAR_SELECTION_BUTTON": "Clear Selection", "ALL_COLLECTIONS_SELECTION_BY_CATEGORIES_TITLE": "Collections in Selected Categories", "HEADER_MY_LISTS": "My Lists", + "SEARCH_PAGE_TITLE": "Search Graasp", "SEARCH_RANGE_LABEL": "Search Range", "SEARCH_RANGES_ALL": "All", "SEARCH_RANGES_TITLE": "Title", diff --git a/src/langs/fr/library.json b/src/langs/fr/library.json index b001ea15..3f953e60 100644 --- a/src/langs/fr/library.json +++ b/src/langs/fr/library.json @@ -27,6 +27,7 @@ "COLLECTION_TAGS_TITLE": "Tags", "COPY_ITEM_MODAL_MY_ITEMS_ROOT": "My Items", "CONTRIBUTORS_TITLE": "avec", + "SEARCH_PAGE_TITLE": "Recherche Graasp", "SEARCH_RANGE_LABEL": "Champ de recherche", "SEARCH_RANGES_ALL": "Tous", "SEARCH_RANGES_TITLE": "Titre", From 98ff29bb4622e1fb155a3d56a9695dbc5a7e63df Mon Sep 17 00:00:00 2001 From: spaenleh Date: Mon, 12 Jun 2023 11:30:44 +0200 Subject: [PATCH 3/4] feat: add home collection titles --- src/constants/library.ts | 3 +++ src/langs/en/library.json | 2 ++ src/langs/fr/library.json | 3 +++ 3 files changed, 8 insertions(+) diff --git a/src/constants/library.ts b/src/constants/library.ts index 74ffa322..09664eb2 100644 --- a/src/constants/library.ts +++ b/src/constants/library.ts @@ -58,6 +58,9 @@ export const LIBRARY = { HOME_TITLE: 'HOME_TITLE', HOME_MORE_COLLECTIONS_TITLE: 'HOME_MORE_COLLECTIONS_TITLE', HOME_GRAASPER_COLLECTIONS_TITLE: 'HOME_GRAASPER_COLLECTIONS_TITLE', + HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE: + 'HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE', + HOME_MOST_LIKED_COLLECTIONS_TITLE: 'HOME_MOST_LIKED_COLLECTIONS_TITLE', MY_LISTS_MY_FAVORITES_TAB: 'MY_LISTS_MY_FAVORITES_TAB', MY_LISTS_MY_PUBLISHMENTS_TAB: 'MY_LISTS_MY_PUBLISHMENTS_TAB', MY_LISTS_MY_LIKES_TAB: 'MY_LISTS_MY_LIKES_TAB', diff --git a/src/langs/en/library.json b/src/langs/en/library.json index de716c6c..532a806a 100644 --- a/src/langs/en/library.json +++ b/src/langs/en/library.json @@ -57,6 +57,8 @@ "HOME_TITLE": "Browse Open Educational Resources", "HOME_MORE_COLLECTIONS_TITLE": "Discover", "HOME_GRAASPER_COLLECTIONS_TITLE": "Graasp Selection", + "HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE": "Popular this Week", + "HOME_MOST_LIKED_COLLECTIONS_TITLE": "Most liked", "MY_LISTS_MY_FAVORITES_TAB": "My Favorites", "MY_LISTS_MY_PUBLISHMENTS_TAB": "My Publishments", "MY_LISTS_MY_LIKES_TAB": "My Likes", diff --git a/src/langs/fr/library.json b/src/langs/fr/library.json index 3f953e60..b4708a62 100644 --- a/src/langs/fr/library.json +++ b/src/langs/fr/library.json @@ -22,6 +22,9 @@ "ALL_COLLECTIONS_TITLE": "Toutes les Collections", "HEADER_ALL_COLLECTIONS": "Toutes les Collections", "HEADER_MY_LISTS": "Mes Listes", + "HOME_GRAASPER_COLLECTIONS_TITLE": "Selection Graasp", + "HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE": "Populaire cette semaine", + "HOME_MOST_LIKED_COLLECTIONS_TITLE": "Les plus aimées", "ALL_COLLECTIONS_OPEN_MENU": "Ouvrir le Menu", "EMPTY_COLLECTION_MESSAGE": "Aucune collection disponible.", "COLLECTION_TAGS_TITLE": "Tags", From d44911022283755365453617b5977c9384301f1d Mon Sep 17 00:00:00 2001 From: Basile Spaenlehauer Date: Wed, 14 Jun 2023 14:02:47 +0200 Subject: [PATCH 4/4] fix(wording): apply suggestions Co-authored-by: Kim Lan Phan Hoang --- src/langs/fr/library.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/langs/fr/library.json b/src/langs/fr/library.json index b4708a62..7b9e5a4c 100644 --- a/src/langs/fr/library.json +++ b/src/langs/fr/library.json @@ -1,7 +1,7 @@ { "COPY_LINK_BUTTON_TOOLTIP": "Copier le lien", "GRAASP_LIBRARY": "Graasp Library", - "GRAASP_LIBRARY_DESCRIPTION": "Graasp Library est une platforme de partage de resources éducatives libres.", +"GRAASP_LIBRARY_DESCRIPTION": "Graasp Library est une plateforme de partage de ressources éducatives libres.", "HOME_TITLE": "Découvrez des ressources libres pour l'éducation", "GUEST": "Invité", "SEARCH_RANGES_AUTHOR": "Auteur", @@ -23,7 +23,7 @@ "HEADER_ALL_COLLECTIONS": "Toutes les Collections", "HEADER_MY_LISTS": "Mes Listes", "HOME_GRAASPER_COLLECTIONS_TITLE": "Selection Graasp", - "HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE": "Populaire cette semaine", +"HOME_POPULAR_THIS_WEEK_COLLECTIONS_TITLE": "Populaires cette semaine", "HOME_MOST_LIKED_COLLECTIONS_TITLE": "Les plus aimées", "ALL_COLLECTIONS_OPEN_MENU": "Ouvrir le Menu", "EMPTY_COLLECTION_MESSAGE": "Aucune collection disponible.",